feat: support Set equality comparison in iterableEquals#198
Open
ShakyaCsun wants to merge 2 commits intofelangel:masterfrom
Open
feat: support Set equality comparison in iterableEquals#198ShakyaCsun wants to merge 2 commits intofelangel:masterfrom
ShakyaCsun wants to merge 2 commits intofelangel:masterfrom
Conversation
- extra checks in iterableEquals caused a performance hit in benchmarks - use propsEquals to compare List<Object?> with no extra checks
Author
return hash ^ (object is List ? 'List${object.length}'.hashCode : object.length);but maybe there's a better way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
IN DEVELOPMENT
Breaking Changes
YES
Description
Add support for equality comparison between all types of Iterable including Sets to
iterableEqualsand subsequently all Equatable objects.Additionally, a
propsEqualsfunction which compares theList<Object?>props is added and used in operator == override for Equatable and EquatableMixin in place of iterableEquals to skip the newly added checks and maintain similar performance in the existing benchmarks.Fixes #196
Impact to Remaining Code Base
This PR will affect:
Benchmarks result from before and after
EmptyEquatable
PrimitiveEquatable
CollectionEquatable (static, small)
CollectionEquatable (static, medium)
CollectionEquatable (static, large)
CollectionEquatable (dynamic, small)
CollectionEquatable (dynamic, medium)
CollectionEquatable (dynamic, large)