Setting to disable "$this can only be used in an object context."

[felixfbecker]

From @Gauss23 on November 20, 2017 15:23

Hello,

we just wondered about a lot of "syntax"-errors in our code. The message is:

$this can only be used in an object context.

Before your update to version 2.0.0 everything was fine. The files IntelliSense is now marking as wrong are config files, which are required/included in object context, so they are perfectly working. Of course IntelliSense cannot know that. Is there a chance to make this check optional?

Best regards,
Christopher

Copied from original issue: felixfbecker/vscode-php-intellisense#201

[felixfbecker]

@Gauss23 is there a way to identify these config files? E.g. do they have a top-level return?

[Gauss23]

Unfortunately no, we are using this in config files and templates. Our renderer is an object, the templates it is parsing are PHP files and are using $this for multiple reasons. PHP is not complaining and everything is working. We don´t want to make too much trouble about it,.

A simple config switch would be sufficient for us. For the majority of the people, the error will be correct.

[felixfbecker]

Want to do a PR?

[Gauss23]

I just looked into the sources. I can see how to add a config var in extension.ts and how to push it as a cmd option to bin/php-language-server.php.
How do you want to push the config variable to the TreeAnalyzer? I saw it´s created by PhpDocument.php.
Using a global would not be the preferred method I think. Is there already some kind of infrastructure to pass something from the outside deeply into the the objects?
Maybe there will be more config settings in the future.

Best regards

[felixfbecker]

No, it would have to implement didChangeConfiguration: https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#workspace_didChangeConfiguration

[Gauss23]

I thought I can add a line in: vscode-php-intellisense/src/extension.ts
Like this line:
const memoryLimit = conf.get<string>('memoryLimit') || '-1';
I would add:
const checkThisInClasses = conf.get<string>('checkThisInClasses') || '1';

And then add a command option in the same file.

Can´t see how to implement didChangeConfiguration, sorry.

[felixfbecker]

That wouldn't help. The configuration can change.

[Gauss23]

At the moment you´re not handling config changes, at least I can´t find an implementation of this didChangeConfiguration in intelliSense.
I´ll try to find an example for this implementation.

[felixfbecker]

Because at the moment there is no config

[Gauss23]

Memory limit and php executable are config variables in VS Code. Am I wrong? What if those settings are changed? Where is the trigger to restart the language-server?
Sorry, those are my first steps with vs code extensions.

[felixfbecker]

Memory limit and PHP executable are settings for the VS Code extension that modify how the language server is spawned, it's not a setting that is used in the language server at runtime or can change. Customisation of the static analysis should happen through the protocol.

[Gauss23]

I see, I think I´ll leave that one for a more experienced vs code extension developer.

Thank you for your patience.