Run 'composer install' in a docker builder stage #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=========================================
Coverage 82.17% 82.17%
Complexity 935 935
=========================================
Files 44 44
Lines 2154 2154
=========================================
Hits 1770 1770
Misses 384 384 |
Dockerfile
Outdated
| RUN composer install | ||
|
|
||
| # Running this container will start a language server that listens for TCP connections on port 2088 | ||
| # Every connection will be run in a forked child process |
Owner
There was a problem hiding this comment.
Can you keep this comment at the top?
Contributor
Author
There was a problem hiding this comment.
Moved the comments back to the top. I also replaced the deprecated maintainer with the appropriate "maintainer" label.
…nstruction with appropriate label
felixfbecker
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered on the comment in the Dockerfile, which says to install the composer dependencies before building the image.
Maybe it is an option for you to use a multi-stage Dockerfile, like i proposed in my PR :) I would appreciate to hear your thoughts about that.