feat(verify): resolve the web template from the registry (1a)#26
Merged
Conversation
verify reads registry.json to find the web template to build and serve, instead of hardcoding the react-vite path. SEAMLESS_REACT_DIR still overrides with a direct path (used by CI); SEAMLESS_TEMPLATES_DIR points at a local templates checkout. When the registry lists more than one web template it logs that only the first runs, so the multi-template gap (#1b) is visible rather than silent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
seamless verifydiscover the web template to conformance-test from the seamless-templates registry instead of a hardcodedreact-vitepath. This is step 1a of registry-driven verify: foundational, single-template behavior unchanged.What changed
resolveReactDir()now readsregistry.jsonfrom the templates checkout (SEAMLESS_TEMPLATES_DIR, default sibling../seamless-templates), filters to runnable web templates (kind: web, notcoming-soon), and resolves the first one's path.SEAMLESS_REACT_DIRstill overrides with a direct template path (used by the reusable conformance workflow), so CI is unaffected.Validation
seamless verify --api-only: 14/14 api flows pass.seamless verify(full browser matrix): 26/26 pass across api, adapter, and react, with the react layer resolved through the new registry path (noSEAMLESS_REACT_DIRset).Follow-up (1b, not in this PR)
Run the browser suite against every web template, which needs each template to declare how it builds and serves (Vite/nginx SPA vs SSR, plus the
--localSDK injection). Best co-developed with the first non-react web template so the contract is validated by real diversity.