Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

added api tests#11

Merged
femueller merged 1 commit intofemueller:masterfrom
gsailer:api-tests
Jan 18, 2019
Merged

added api tests#11
femueller merged 1 commit intofemueller:masterfrom
gsailer:api-tests

Conversation

@gsailer
Copy link
Copy Markdown
Contributor

@gsailer gsailer commented Dec 29, 2018

Hi @femueller
Following up to #8 and #3 I started with the unit testing for the api.
I'm not sure if there is any use to testing all the methods, which only access the api and return a json.
Maybe you have an idea how to handle this. For now I only tested the first of those methods.

@femueller
Copy link
Copy Markdown
Owner

I think it's definitely fine like that for now.
Thanks for the submission! 👍

@femueller femueller merged commit c3390a2 into femueller:master Jan 18, 2019
@gsailer gsailer deleted the api-tests branch January 18, 2019 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants