This repository was archived by the owner on Oct 29, 2023. It is now read-only.
Added many missing API methods#14
Merged
femueller merged 1 commit intofemueller:masterfrom Mar 9, 2019
markusressel:feature/spaces
Merged
Added many missing API methods#14femueller merged 1 commit intofemueller:masterfrom markusressel:feature/spaces
femueller merged 1 commit intofemueller:masterfrom
markusressel:feature/spaces
Conversation
markusressel
commented
Mar 7, 2019
markusressel
commented
Mar 7, 2019
markusressel
commented
Mar 7, 2019
Owner
|
Thanks for your contribution! The only thing I would propose before merging is to roll back the formatting by PyCharm in the test files because it seems a little off. |
femueller
suggested changes
Mar 8, 2019
Collaborator
Author
|
@femueller It's just formatted according to specification, line breaks could be added though. I will revert this (in a couple of hours). |
added api method to query available categories added api method to query invitations added api method to query statistics for a given timeframe added api method to query standing orders added api method to query savings added query parameters to get_transactions method deprecated get_transactions_limited (now uses get_transactions with parameter) added url parameter handling to _do_request raise exception for http result codes other than 200 refactoring to reduce copy&paste code added missing test dependencies to setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to query the following things:
I also added some parameters to the transactions API method.
To do this and make it easier for future requests I also did some refactoring to remove all the copy&paste code - I hope this is in your interest too.
Because I ran into strange json errors when the server wasn't responding as expected I also added a
result.raise_for_status()call so http response codes other than 200 will be raised as an exception before trying to parse the result as a json.I saw that @sdabbo created a PR for spaces support that also adds some code to the cli.
I dit not add any code for the cli because I don't need it. It might be useful to merge his PR and then let me fix any merge conflicts and merge this PR after that.
I used this very helpful (inofficial) API description from this repo:
https://github.com/Rots/n26-api
Some of the methods there didn't work so I didn't add them.
I also didn't try every single thing listed there, just the stuff I found generally interesting.