This repository was archived by the owner on Oct 29, 2023. It is now read-only.
Merged
Conversation
do not limit transactions output if --from parameter is set print date of transaction allow the use of --from and --to independent from one another
use datetime input for statistics command as well added datetime formats added arguments to test
markusressel
commented
Sep 10, 2019
|
|
||
| return extractor | ||
|
|
||
|
|
Collaborator
Author
There was a problem hiding this comment.
This method has just moved, nothing changed.
markusressel
commented
Sep 10, 2019
| if param_to is not None: | ||
| if param_from is None: | ||
| # if --to is set, --from must also be set | ||
| from_timestamp = 1 |
Collaborator
Author
There was a problem hiding this comment.
I'm using 1 here since 0 acted like None.
That is the reason I added the > 0 thingy to the API documentation.
femueller
approved these changes
Sep 17, 2019
Owner
|
@markusressel Looks good to me |
Collaborator
Author
|
I would like to hold back on merging this until the general functionality of the library is restored since it might introduce unforeseen problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now the
--fromand--tocli parameters have been timestamps since 1970 CET.In practice this is unusable for a human though, so I changed this to support human readable datetime string input formats. Accepted formats are listed in the
const.py:%m/%d/%Y %H:%M:%S%m/%d/%Y%Y-%m-%d%Y-%m-%dT%H:%M:%S%Y-%m-%d %H:%M:%S%d.%m.%Y%d.%m.%Y %H:%M:%SI also plan on adding a
--durationparameter that allows a user to easily get a specific time range without having to calculate the dates him- or herself.This PR also adds a
Datecolumn to thetransactionsoutput.