Skip to content

Release based on pushed tag instead of hardcoded nightly tags#1

Merged
fengqi-dev merged 2 commits into
mainfrom
copilot/update-workflow-for-tag-release
Mar 2, 2026
Merged

Release based on pushed tag instead of hardcoded nightly tags#1
fengqi-dev merged 2 commits into
mainfrom
copilot/update-workflow-for-tag-release

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 2, 2026

Workflow always published to fixed vscode-nightly / cursor-nightly releases regardless of the triggering tag, making tag-based versioning impossible.

Changes

  • Consolidated two separate release steps into one Publish release step
  • Release name and tag now use ${{ github.ref_name }} — pushing v1.0.0 creates a v1.0.0 release
  • Removed prerelease: true so releases are stable by default
  • All four artifacts (vscode + cursor tarballs and checksums) published under the single tag-named release

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: fengqi-dev <10048504+fengqi-dev@users.noreply.github.com>
Copilot AI changed the title [WIP] Update workflow to publish based on tag Release based on pushed tag instead of hardcoded nightly tags Mar 2, 2026
@fengqi-dev fengqi-dev marked this pull request as ready for review March 2, 2026 02:47
Copilot AI review requested due to automatic review settings March 2, 2026 02:47
@fengqi-dev fengqi-dev merged commit 35a0a66 into main Mar 2, 2026
2 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release workflow so GitHub Releases are created using the pushed tag name (instead of hardcoded nightly tags), enabling tag-based versioning for published tarball artifacts.

Changes:

  • Consolidates two separate release publishing steps into a single release publish step.
  • Uses ${{ github.ref_name }} for both release name and tag name.
  • Publishes both VS Code and Cursor tarballs (and SHA256SUMS) under the same tag-named release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to 41
- name: Publish release
uses: softprops/action-gh-release@v2
with:
name: vscode-nightly
tag_name: vscode-nightly
name: ${{ github.ref_name }}
tag_name: ${{ github.ref_name }}
target_commitish: ${{ github.sha }}
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_dispatch can be run from a branch (e.g., main), and with the current config that would attempt to create/update a release tagged main. If the intent is “releases are only created for tags”, add a guard (e.g., if: startsWith(github.ref, 'refs/tags/')) on the publish step/job, or require an explicit tag input for workflow_dispatch and use that for tag_name/name.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants