fix(llm): move default_bindings INSIDE configure() — Alt+* keys were dead#72
Merged
Conversation
…dead Regression from #70: `default_bindings` sat at the top level of `src/modules/llm.zig`, but `config.modules` actually stores the RESULT of `llm.configure(.{...})` — i.e. the inner struct returned by the factory. The dispatcher's `@hasDecl(M, "default_bindings")` gate inspects the inner struct, so the top-level decl was invisible and every Alt+letter LLM binding silently missed. Fix: move the slice into the `configure()` return type alongside `name`, `config`, the action handlers, etc. — same scope `@hasDecl` walks for every other hook on the LLM module. Regression test (`allDefaultBindings: picks up bindings from configure()-style factory modules`) mirrors the real `pub fn configure(cfg) type` pattern via a `FactoryModule(tag)` fixture, so future module authors don't re-hit this trap. `zig build test` (484 pass) + `zig fmt --check` clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Regression from PR #70: every LLM Alt+letter binding silently missed. User report:
Cause
`default_bindings` was declared at the top level of `src/modules/llm.zig`, but `config.modules` actually stores the result of `llm.configure(.{...})` — i.e. the inner struct returned by the factory. The dispatcher walks that inner type with `@hasDecl(M, "default_bindings")`, so the top-level decl was invisible.
The pre-existing dispatch tests passed because the test fixtures (`ModuleWithBindings`) declared `default_bindings` directly on the struct — no `configure()` wrapper. They didn't exercise the real shape user configs use.
Fix
Move the slice INSIDE the `configure()` return type, alongside `name`, `config`, the action handlers, etc. — same scope `@hasDecl` walks for every other hook on the LLM module.
Regression test
New `FactoryModule(tag)` test fixture in `src/dispatch.zig` mirrors the real `pub fn configure(cfg) type` pattern and asserts the walker picks up both modules' `default_bindings`. Future module authors will trip the test if they put the decl at the wrong scope.
Test plan
🤖 Generated with Claude Code