Custom imports fixes for #41, revisiting #12#44
Merged
marcmengel merged 2 commits intomainfrom Oct 22, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, "import custom" will not throw if there is a "custom" directory in the PYTHONPATH, even if the init.py is missing; but you can check that custom.file is set to something and that raises if its there but a directory.
similarly, we check for the import of template_tags in the startup when we run so we can log and stub in a
substitute. Still not sure why that didn't work at the outer scope, but it seems to work here...