Stealing token compat from ifdh.cfg for fake_ifdh.py#562
Merged
Conversation
shreyb
requested changes
Apr 5, 2024
Collaborator
shreyb
left a comment
shreyb
left a comment
There was a problem hiding this comment.
Looks good, but two things.
- Could you please update the submodule commit hash?
- I think the answer is yes to this question, but just to be sure - by putting this new setting in
gfal_clean_env, we're making sure it only gets used in the various gfal commands here in fake_ifdh, correct?
Contributor
Author
|
RIght; so that only happens in the subshell we run the gfal-copy in; we scrub the various PYTHON related variables (because the gfal developers don't know about |
shreyb
approved these changes
Apr 5, 2024
Collaborator
shreyb
left a comment
shreyb
left a comment
There was a problem hiding this comment.
Cool - I just did a quick test, and this worked as advertised. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token-only launches were failing to copy sandbox files at launch... Needed
BEARER_TOKEN set in the environment for gfal utilities. Fixes #561