Skip to content

Added env JOBSUB_MANAGED_TOKEN to control --managed-token flag default#598

Merged
marcmengel merged 1 commit intofermitools:masterfrom
shreyb:managed-token-env
Feb 5, 2025
Merged

Added env JOBSUB_MANAGED_TOKEN to control --managed-token flag default#598
marcmengel merged 1 commit intofermitools:masterfrom
shreyb:managed-token-env

Conversation

@shreyb
Copy link
Copy Markdown
Collaborator

@shreyb shreyb commented Feb 4, 2025

This PR adds an environment variable, JOBSUB_MANAGED_TOKEN, corresponding to the new --managed-token flag, that allows users to set that flag in the environment

# Default behavior
$  bin/jobsub_submit -G fermilab -n --debug file:///usr/bin/true
...
varg: {...  'managed_token': False, 'memory': '2GB', ...}
...

# With flag
$  bin/jobsub_submit -G fermilab -n --debug --managed-token file:///usr/bin/true
...
varg: {... 'managed_token': True, 'memory': '2GB', ...}
...

# With env
$ JOBSUB_MANAGED_TOKEN=1 bin/jobsub_submit -G fermilab -n --debug file:///usr/bin/true
...
varg: {...  managed_token': True, 'memory': '2GB', ...}
...

There are also a couple of tests that check this.

@shreyb shreyb added this to the 1.10 milestone Feb 4, 2025
@shreyb shreyb requested a review from marcmengel February 4, 2025 23:07
Copy link
Copy Markdown
Contributor

@marcmengel marcmengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@marcmengel marcmengel merged commit 263aab3 into fermitools:master Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants