Skip to content

Conversation

@vdice
Copy link
Member

@vdice vdice commented Aug 17, 2023

Previously, tags weren't actually fetched, throwing off the canaryExists logic.

Interestingly, tags still won't be fetched when fetch-depth is > 0 (as is the default, being 1), even when toggling fetch-tags: true on the checkout action. (See actions/checkout#701).

Therefore, I just add a git fetch --prune --unshallow --tags to start the step. (Prefer not to set fetch-depth to 0 and thus fetch all git history.)

Depends on #3 (will convert from Draft once merged)

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice force-pushed the ci/fix-canary-exists branch from 7740dd1 to f20fac8 Compare August 24, 2023 17:36
@vdice vdice marked this pull request as ready for review August 24, 2023 17:36
@vdice vdice merged commit 29a1b60 into fermyon:main Aug 24, 2023
@vdice vdice deleted the ci/fix-canary-exists branch August 24, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant