Fix changelog icon CSS to only target sidebar links #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the CSS selector from 'a[href$="changelog"] svg' to '.fern-sidebar-link.nested[href$="changelog"] > svg' to specifically target only the SVG icon within the sidebar changelog link. This prevents the rule from inadvertently hiding all SVGs on changelog pages that have links attached to them, while still hiding the changelog icon in the sidebar navigation as intended. Co-Authored-By: Kapil Gowru <k.gowru@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Updated selector from '.fern-sidebar-link.nested[href$="changelog"]' to '.fern-sidebar-link[href$="changelog"]' to apply to all sidebar changelog links regardless of whether they have the nested class. Co-Authored-By: Kapil Gowru <k.gowru@gmail.com>
Contributor
fern-support
approved these changes
Oct 21, 2025
fern-support
pushed a commit
that referenced
this pull request
Oct 21, 2025
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Kapil Gowru <k.gowru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix changelog icon CSS to only target sidebar links
Summary
Updated the CSS selector for hiding changelog icons from
a[href$="changelog"] svgto.fern-sidebar-link[href$="changelog"] > svg. The original selector was too broad and was inadvertently hiding all SVGs within links on changelog pages, not just the sidebar icon.Changes:
.fern-sidebar-linkclass requirement to target only sidebar links>) for better specificity.nestedclass requirement to work with all sidebar changelog linksReview & Testing Checklist for Human
Test Plan
/learn/sdks/generators/typescript/changelog)Notes
fern docs devon the TypeScript changelog pageLink to Devin run: https://app.devin.ai/sessions/aae1210399814b7585b6f287e878e2c9
Requested by: Kapil Gowru (@kgowru)