Skip to content

fix(java): Fix java local github generation to match remote generation#10501

Merged
jsklan merged 9 commits intomainfrom
jsklan/java-loc-rem-parity-3
Nov 12, 2025
Merged

fix(java): Fix java local github generation to match remote generation#10501
jsklan merged 9 commits intomainfrom
jsklan/java-loc-rem-parity-3

Conversation

@jsklan
Copy link
Copy Markdown
Contributor

@jsklan jsklan commented Nov 12, 2025

Description

This PR fixes inconsistent behavior between local and remote Java SDK generation, ensuring that both scenarios produce identical output with proper license files and platform headers.

The issue was that local generation (when using --local flag) was missing license files and had incomplete platform header information compared to remote generation via Fiddle. This created confusing differences in generated SDKs depending on the generation mode used.

Changes Made

  • License file handling: Added copyLicenseFile() method to consistently copy license files in all generation scenarios (GitHub, Maven, filesystem)
  • Platform headers fallback: Enhanced ClientOptionsGenerator to use IR publishConfig when generatorConfig.publish is unavailable (local generation scenario)
  • Consistent generation flow: All three generation paths now include proper license and header handling

Testing

  • Manual testing completed for both local and remote generation scenarios
  • Verified license files are properly included in local generation output
  • Confirmed platform headers are populated correctly in both modes

@jsklan jsklan marked this pull request as ready for review November 12, 2025 00:39
@jsklan jsklan changed the title fix(cli, java): Fix java local github generation to match remote generation fix(java): Fix java local github generation to match remote generation Nov 12, 2025
@jsklan jsklan merged commit 8b55eb0 into main Nov 12, 2025
126 checks passed
@jsklan jsklan deleted the jsklan/java-loc-rem-parity-3 branch November 12, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants