Skip to content

fix(cli, go): Fix go local github generation to match remote generation#10506

Merged
jsklan merged 12 commits intomainfrom
jsklan/go-loc-rem-parity-2
Nov 12, 2025
Merged

fix(cli, go): Fix go local github generation to match remote generation#10506
jsklan merged 12 commits intomainfrom
jsklan/go-loc-rem-parity-2

Conversation

@jsklan
Copy link
Copy Markdown
Contributor

@jsklan jsklan commented Nov 12, 2025

Description

This PR fixes a mismatch between local and remote Go SDK generation by ensuring the CLI can properly retrieve the package name from module.path configuration during local generation workflows. Previously, local generation was failing because the package name couldn't be extracted from the generator configuration, while remote generation (via Fiddle) worked correctly.

Changes Made

  • CLI package name extraction: Added support for reading module.path from Go generator config in local workspace runner
  • Version normalization: Go generator now adds 'v' prefix to version strings following Go conventions
  • Custom license file support: Go v2 generator now copies custom LICENSE files during local generation (remote generation handled by Fiddle)

Testing

  • Manual testing completed with local generation
  • Verified version normalization with/without 'v' prefix
  • Tested custom license file copying in local generation environment

@jsklan jsklan marked this pull request as ready for review November 12, 2025 04:25
@jsklan jsklan merged commit 1a8dce4 into main Nov 12, 2025
132 checks passed
@jsklan jsklan deleted the jsklan/go-loc-rem-parity-2 branch November 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants