fix(cli, go): Fix go local github generation to match remote generation#10506
Merged
fix(cli, go): Fix go local github generation to match remote generation#10506
Conversation
...cli/generation/local-generation/local-workspace-runner/src/runLocalGenerationForWorkspace.ts
Show resolved
Hide resolved
musicpulpite
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a mismatch between local and remote Go SDK generation by ensuring the CLI can properly retrieve the package name from
module.pathconfiguration during local generation workflows. Previously, local generation was failing because the package name couldn't be extracted from the generator configuration, while remote generation (via Fiddle) worked correctly.Changes Made
module.pathfrom Go generator config in local workspace runnerTesting