fix(openapi): handle discriminator mapping without oneOf in both conversion paths #11406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Refs: Slack thread from Sandeep Dinesh
Link to Devin run: https://app.devin.ai/sessions/eddb3e06655c47ec89a88b5bced08a4e
Requested by: Sandeep Dinesh (@thesandlord)
Fixes handling of OpenAPI schemas that have
discriminator.mappingbut no explicitoneOf/anyOf. This pattern is used by some APIs (like Dropbox Sign) where a base schema defines a discriminator with mapping to variant schemas, but doesn't list them in aoneOf.Previously, such schemas were incorrectly converted as plain objects. Now they are properly converted as discriminated unions.
Changes Made
tryConvertDiscriminatorMappingSchema()method inSchemaConverter.ts(for--from-openapidirect path) that:discriminator.mappingbut nooneOf/anyOfoneOffrom the mapping valuesOneOfSchemaConverterfor proper discriminated union conversionconvertSchemas.ts(for OpenAPI→Fern conversion path) that:discriminator.mappingpatternconvertDiscriminatedOneOfwhich uses the mapping internally to build union subtypesdiscriminator-base-classdemonstrating this patternUpdates since last revision
versions.ymlTesting
Human Review Checklist
discriminator.mappingexists but the schema should remain an objectconvertDiscriminatedOneOfdirectly without synthesizing oneOf first - verify this is correct sinceconvertDiscriminatedOneOfusesdiscriminator.mappinginternally (line 51-74 of convertDiscriminatedOneOf.ts)