fix(typescript): drop nullable enum query params when undefined instead of sending null #11510
+15
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where nullable enum query parameters were being set to
nullinstead of being dropped whenundefinedwas passed to the client's endpoint method.Link to Devin run: https://app.devin.ai/sessions/14148495a6164918b8e1c446d85c413d
Requested by: @jsklan
Changes Made
TypeReferenceToStringExpressionConverter.convertWithNullCheckIfOptional()to returnundefinedinstead ofnullfor nullable types when the value isundefinedversions.ymlwith changelog entry for v3.43.9nullable-optionalto reflect the corrected generated codeBefore:
After:
Testing
nullable-optionalfixture - passedenumfixture (3 configs) - passedexhaustivefixture (21 configs) - passedHuman Review Checklist
nullmight be semantically meaningful (the methodconvertWithNullCheckIfOptionalcould be called from other contexts)undefinedto a nullable query param, it should be dropped from the request rather than sent as an empty value