Skip to content

fix(csharp): RetriesTest.cs uses correct JSON serialization formatting#13517

Merged
patrickthornton merged 6 commits intomainfrom
patrick/csharp/test-formatting
Mar 13, 2026
Merged

fix(csharp): RetriesTest.cs uses correct JSON serialization formatting#13517
patrickthornton merged 6 commits intomainfrom
patrick/csharp/test-formatting

Conversation

@patrickthornton
Copy link
Contributor

Description

The generated C# SDK retry tests (ShouldPreserveJsonBody_OnRetry and ShouldPreserveMultipartBody_OnRetry) were asserting compact JSON strings, but the SDK's JsonConfiguration serializes with WriteIndented = true, producing pretty-printed JSON. This PR updates generators/csharp/base/src/asIs/test/RawClientTests/RetriesTests.Template.cs to expect indented JSON output.

Testing

Seed; the MyOrg Auth0 API was failing these tests before.

  • Unit tests added/updated
  • Manual testing completed

@github-actions
Copy link
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

patrickthornton and others added 2 commits March 13, 2026 13:49
…ts.Template.cs

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
@patrickthornton patrickthornton merged commit 34065b3 into main Mar 13, 2026
87 checks passed
@patrickthornton patrickthornton deleted the patrick/csharp/test-formatting branch March 13, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants