Skip to content

chore(typescript): rename shouldGenerateWebsocketClients to generateWebSocketClients#13562

Merged
fern-support merged 2 commits intomainfrom
devin/1773633322-rename-websocket-clients-config
Mar 16, 2026
Merged

chore(typescript): rename shouldGenerateWebsocketClients to generateWebSocketClients#13562
fern-support merged 2 commits intomainfrom
devin/1773633322-rename-websocket-clients-config

Conversation

@Swimburger
Copy link
Member

@Swimburger Swimburger commented Mar 16, 2026

Description

Renames the shouldGenerateWebsocketClients configuration option to generateWebSocketClients (also fixes casing: WebsocketWebSocket). The old name is preserved as a deprecated fallback for backwards compatibility.

Changes Made

  • Moved shouldGenerateWebsocketClients to the deprecated section of TypescriptCustomConfigSchema and added generateWebSocketClients as the primary field
  • Updated SdkGeneratorCli.ts parsing to prefer generateWebSocketClients with fallback to shouldGenerateWebsocketClients
  • Renamed all internal usages across SdkCustomConfig, SdkGenerator, SdkClientClassGenerator, and GeneratedSdkClientClassImpl
  • Updated test files and seed fixtures (seed.yml, metadata.json) to use the new name
  • Added versions.yml entry (v3.56.2)

Review Checklist

  • Verify backwards compat fallback in SdkGeneratorCli.ts:51parsed?.generateWebSocketClients ?? parsed?.shouldGenerateWebsocketClients ?? false
  • Confirm the Zod strictObject still accepts the old field name (it's kept in the schema's deprecated section at line 102)
  • No remaining references to the old name outside of the deprecated fallback path and Zod schema

Testing

  • pnpm run check (biome) passes
  • pnpm format applied
  • All CI checks passed (compile, test, seed tests, lint)

Link to Devin session: https://app.devin.ai/sessions/d8ce068101844e7b8b41db4d4546b912
Requested by: @Swimburger


Open with Devin

…ebSocketClients

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@claude
Copy link

claude bot commented Mar 16, 2026

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@fern-support fern-support enabled auto-merge (squash) March 16, 2026 04:17
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@fern-support fern-support merged commit 0491795 into main Mar 16, 2026
88 checks passed
@fern-support fern-support deleted the devin/1773633322-rename-websocket-clients-config branch March 16, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants