feat(python): add aiohttp auto-detection to Python SDK generator by jsklan · Pull Request #13586 · fern-api/fern

jsklan · 2026-03-16T21:41:42Z

Description

Auto-detect httpx_aiohttp at runtime and use it for the async HTTP client when available, falling back to plain httpx.AsyncClient.

Changes Made

Async client auto-detection: Add _make_default_async_client() helper in client.py that tries httpx_aiohttp.HttpxAiohttpClient first, falling back to httpx.AsyncClient
Convenience classes: Add _default_clients.py module with DefaultAioHttpClient and DefaultAsyncHttpxClient classes with SDK-appropriate defaults
Optional dependencies: Add aiohttp and httpx-aiohttp as optional deps exposed via a [aiohttp] pip extra in pyproject.toml; correctly excluded from requirements.txt
Test generation: Generate pytest-based aiohttp tests with @pytest.mark.aiohttp marker, auto-skip logic in conftest.py, and a mock-based bypass test
CI two-pass testing: Standard tests then pytest -m aiohttp after installing the extra
Generator hardening: Add package_name validation before f-string interpolation in generated test files; merge (not overwrite) user-defined extras
Version entry: Add versions.yml entry for v5.3.0
ETE timeout fix: Increase vitest timeouts for basic generation tests from 60s → 180s to match internal cliV2.generate process timeout

Testing

pytest -m "not aiohttp" — fallback behavior without httpx_aiohttp
pip install httpx-aiohttp && pytest -m "aiohttp" — autodetect with httpx_aiohttp installed
Seed fixture output validated (seed/python-sdk/exhaustive/no-custom-config)
test-ete CI check passes with increased timeouts

Link to Devin session: https://app.devin.ai/sessions/2562e5b9bd6a4be7a5756c141751c323

claude · 2026-03-16T21:41:46Z

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

When httpx_aiohttp is installed, the async client automatically uses it instead of plain httpx.AsyncClient. Adds DefaultAioHttpClient and DefaultAsyncHttpxClient convenience classes with SDK defaults.

…pass Fix mypy errors by adding type: ignore comments for optional httpx_aiohttp imports and widening timeout param to Optional[float]. Add conftest hook to auto-skip @pytest.mark.aiohttp tests when the package is missing. Update CI to run a second test pass after installing the aiohttp extra.

…dule pollution Co-Authored-By: bot_apk <apk@cognition.ai>

…h internal process timeout The python remote generation can take >60s, causing the vitest 60s timeout to fire before cliV2.generate's internal 180s process timeout. Increased both python and go basic generation test timeouts to 180_000ms to match. Co-Authored-By: bot_apk <apk@cognition.ai>

Add aiohttp as explicit optional dep alongside httpx-aiohttp, bump httpx-aiohttp floor to >=0.1.8, and tighten _make_default_async_client timeout param to non-optional float.

- Move `import seed._default_clients` before `mock.patch.dict` so the module stays in sys.modules after the context manager restores state, fixing the ImportError on cleanup reload - Revert _make_default_async_client timeout param to Optional[float] to satisfy mypy (the ternary _defaulted_timeout can't be narrowed) - Update poetry.lock for new aiohttp optional dep

) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

- Merge user-defined extras with built-in aiohttp deps instead of overwriting - Validate package_name before interpolating into generated test code - Fix no-op bypass test to actually verify _make_default_async_client is skipped - Add versions.yml changelog entry for the aiohttp auto-detection feature

generators/python/src/fern_python/generators/sdk/sdk_generator.py

…tection - Remove unnecessary module_path validation that defended against a non-applicable code injection threat (module_path comes from user's own Fern config, not untrusted input) - Generate minimal tests/conftest.py with aiohttp skip hook for non-wire-test projects so @pytest.mark.aiohttp tests are auto-skipped when httpx_aiohttp is not installed (wire-test projects already get this from WireTestSetupGenerator)

devin-ai-integration

Devin Review found 1 new potential issue.

View 9 additional findings in Devin Review.

generators/python/src/fern_python/generators/sdk/sdk_generator.py

The generated aiohttp test was hardcoding `from {module_path}.client` but the SDK generator supports custom client filenames via `client_filename` or `client.filename` config. Derive the module name from the configured filename so the test imports resolve correctly.

generators/python/src/fern_python/generators/sdk/sdk_generator.py

jsklan self-assigned this Mar 16, 2026

devin-ai-integration bot force-pushed the jsklan/aiohttp-python branch from 1313402 to 8aa128a Compare March 19, 2026 22:09

This comment was marked as resolved.

Sign in to view

devin-ai-integration bot force-pushed the jsklan/aiohttp-python branch from 8aa128a to 0bab983 Compare March 20, 2026 20:29

fern-support marked this pull request as draft March 24, 2026 13:42

jsklan mentioned this pull request Apr 1, 2026

feat(python): add aiohttp auto-detection to Python SDK generator #14469

Merged

2 tasks

jsklan and others added 7 commits April 2, 2026 14:01

feat(python): add aiohttp auto-detection for async HTTP client

010f73c

When httpx_aiohttp is installed, the async client automatically uses it instead of plain httpx.AsyncClient. Adds DefaultAioHttpClient and DefaultAsyncHttpxClient convenience classes with SDK defaults.

fix(python): move importlib.reload outside mock context to prevent mo…

4759645

…dule pollution Co-Authored-By: bot_apk <apk@cognition.ai>

fix(python): align aiohttp seed fixture with cohere-python PR 739

060625b

Add aiohttp as explicit optional dep alongside httpx-aiohttp, bump httpx-aiohttp floor to >=0.1.8, and tighten _make_default_async_client timeout param to non-optional float.

feat(python): add aiohttp auto-detection to Python SDK generator (#14469

645e614

) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

jsklan force-pushed the jsklan/aiohttp-python branch from e4352e5 to 645e614 Compare April 2, 2026 18:02

jsklan marked this pull request as ready for review April 2, 2026 18:11

claude bot reviewed Apr 2, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

jsklan added 2 commits April 2, 2026 14:47

update generator and miinor updates

4632d03

correct handling of optional deps in requirements.txt

f933efa

This comment was marked as resolved.

Sign in to view

jsklan added 2 commits April 2, 2026 15:45

updates

5026e68

jsklan changed the title ~~feat(python): add aiohttp auto-detection for async HTTP client~~ feat(python): add aiohttp auto-detection to Python SDK generator Apr 2, 2026

update exhaustive

e477713

fern-support approved these changes Apr 2, 2026

View reviewed changes

update test script

38a72d3

graphite-app bot reviewed Apr 2, 2026

View reviewed changes

generators/python/src/fern_python/generators/sdk/sdk_generator.py Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

jsklan added 2 commits April 2, 2026 18:46

format

54c3985

devin-ai-integration bot reviewed Apr 2, 2026

View reviewed changes

generators/python/src/fern_python/generators/sdk/sdk_generator.py Outdated Show resolved Hide resolved

jsklan added 2 commits April 2, 2026 19:01

update exhaustive fixture outputs

eb203ee

fern-api deleted a comment from hex-security-app bot Apr 3, 2026

Merge remote-tracking branch 'origin/main' into jsklan/aiohttp-python

b8688af

hex-security-app bot reviewed Apr 3, 2026

View reviewed changes

generators/python/src/fern_python/generators/sdk/sdk_generator.py Show resolved Hide resolved

jsklan added 2 commits April 3, 2026 13:31

pin ir version to 65 temporarily in the python deserialization tests

43a89e0

nit

c9e5113

jsklan merged commit d4aaac3 into main Apr 3, 2026
185 of 188 checks passed

jsklan deleted the jsklan/aiohttp-python branch April 3, 2026 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(python): add aiohttp auto-detection to Python SDK generator#13586

feat(python): add aiohttp auto-detection to Python SDK generator#13586
jsklan merged 20 commits intomainfrom
jsklan/aiohttp-python

jsklan commented Mar 16, 2026 •

edited

Loading

Uh oh!

claude bot commented Mar 16, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

claude bot left a comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

jsklan commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Testing

Uh oh!

claude bot commented Mar 16, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

jsklan commented Mar 16, 2026 •

edited

Loading