fix(typescript): export Socket class from subpackage exports.ts when websocket clients are generated#13638
Merged
fern-support merged 2 commits intomainfrom Mar 17, 2026
Conversation
…t clients are generated Co-Authored-By: Niels Swimberghe <3382717+Swimburger@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage. Once credits are available, reopen this pull request to trigger a review. |
Co-Authored-By: Niels Swimberghe <3382717+Swimburger@users.noreply.github.com>
fern-support
approved these changes
Mar 17, 2026
Contributor
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When WebSocket clients are generated in the TypeScript SDK, the generated
Socketclass (e.g.RealtimeSocket) was not exported from the subpackage'sexports.tsfile. Only theClientclass was exported, making theSocketclass inaccessible through the public exports path (src/exports.ts → core/exports.ts → ...).Changes Made
SdkGenerator.ts: IngenerateSubpackageExports(), added a named export for the Socket class from./client/SocketwhengenerateWebSocketClientsis enabled and the package has a websocket channel. The export is placed between the Client export and the wildcard./client/indexre-export.exports.tsfiles (websocket,websocket-bearer-auth,websocket-inferred-auth) to include the new Socket export.versions.yml: Added version 3.58.1 changelog entry.Review Checklist
this.generateWebSocketClients && package_.websocket != null) correctly limits the export to only packages with an actual websocket channelpackageId.subpackageIdis safe —packageId.isRootis checked false at the top of the loop before this code runsTesting
no-serde,serde,bearer-auth,inferred-auth)Link to Devin session: https://app.devin.ai/sessions/507b82611d614885a0f11aba0b995f5e
Requested by: @Swimburger