chore(seed): add SSE event with protocol-level discriminant key collision#13991
Merged
chore(seed): add SSE event with protocol-level discriminant key collision#13991
Conversation
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
fern-support
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fern-support
approved these changes
Mar 24, 2026
HoaX7
pushed a commit
to HoaX7/fern
that referenced
this pull request
Mar 25, 2026
…sion (fern-api#13991) * Update test definition * chore: update test snapshots * dedupe name in yml, remove test case that confuses fern check * chore: update test snapshots * Move server-sent-event-examples to allowedFailures for go-model, csharp-sdk, and csharp-model --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #13940. Updates the
server-sent-event-examplestest definition to cover the edge case where an SSE event's data contains a key (event) that collides with the protocol-level SSE discriminant field.Changes Made
notificationvariant toeventinStreamEventContextProtocol, so the discriminant value matches a field name in the event dataevent: stringproperty toEventEvent, creating a payload that contains the same key as the SSE protocol discriminanteventvariant with bothnameandeventfields in the data payloadTesting