Skip to content

fix(generator-cli): include version in Gradle installation snippet for Java SDKs#14043

Merged
jsklan merged 3 commits intomainfrom
devin/1774458851-java-gradle-version
Mar 25, 2026
Merged

fix(generator-cli): include version in Gradle installation snippet for Java SDKs#14043
jsklan merged 3 commits intomainfrom
devin/1774458851-java-gradle-version

Conversation

@jsklan
Copy link
Copy Markdown
Contributor

@jsklan jsklan commented Mar 25, 2026

Description

The generated README.md for Java SDKs included the version number in the Maven installation snippet but omitted it from the Gradle snippet, making the Gradle example non-functional.

Before:

dependencies {
  implementation 'io.intercom:intercom-java'
}

After:

dependencies {
  implementation 'io.intercom:intercom-java:3.0.0'
}

Changes Made

  • Added ${maven.version} to the Gradle implementation line in packages/generator-cli/src/readme/ReadmeGenerator.ts (one-line fix, matching the Maven snippet which already included the version)
  • Updated 7 generator-cli test snapshots to reflect the new format
  • Updated ~150 seed Java SDK README snapshots with the version suffix
  • Added 0.6.12 changelog entry in packages/generator-cli/versions.yml
  • Bumped Fern CLI version to 4.43.3 in packages/cli/cli/versions.yml so the fix ships in the next CLI release

Testing

  • Unit test snapshots updated (generator-cli basic-java + custom-sections/java)
  • Seed test results passing (java-sdk and all other generators)
  • Manual testing completed

Important Review Notes

  • The seed README updates were applied via sed rather than by re-running the seed generator. CI seed tests pass, confirming the snapshots match generated output.
  • The core fix is a single-character-level change on one line in ReadmeGenerator.ts:592 — everything else is snapshot/fixture updates.

Human Review Checklist

  • Verify 4.43.3 is the correct next CLI version (latest is 4.43.2)
  • Confirm irVersion: 65 is correct for the new CLI changelog entry
  • Spot-check a few seed README diffs to confirm the :0.0.1 suffix looks right

Link to Devin session: https://app.devin.ai/sessions/d0644705d81c41bbb4034d4e2345b110
Requested by: @jsklan


Open with Devin

…r Java SDKs

Co-Authored-By: judah <jsklan.development@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

@jsklan jsklan marked this pull request as ready for review March 25, 2026 17:23
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

@jsklan jsklan enabled auto-merge (squash) March 25, 2026 17:23
@jsklan jsklan disabled auto-merge March 25, 2026 17:24
Co-Authored-By: judah <jsklan.development@gmail.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Co-Authored-By: judah <jsklan.development@gmail.com>
@jsklan jsklan merged commit e41d028 into main Mar 25, 2026
64 checks passed
@jsklan jsklan deleted the devin/1774458851-java-gradle-version branch March 25, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants