fix(generator-cli): include version in Gradle installation snippet for Java SDKs#14043
Merged
fix(generator-cli): include version in Gradle installation snippet for Java SDKs#14043
Conversation
…r Java SDKs Co-Authored-By: judah <jsklan.development@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
fern-support
approved these changes
Mar 25, 2026
Co-Authored-By: judah <jsklan.development@gmail.com>
Co-Authored-By: judah <jsklan.development@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The generated README.md for Java SDKs included the version number in the Maven installation snippet but omitted it from the Gradle snippet, making the Gradle example non-functional.
Before:
dependencies { implementation 'io.intercom:intercom-java' }After:
dependencies { implementation 'io.intercom:intercom-java:3.0.0' }Changes Made
${maven.version}to the Gradleimplementationline inpackages/generator-cli/src/readme/ReadmeGenerator.ts(one-line fix, matching the Maven snippet which already included the version)0.6.12changelog entry inpackages/generator-cli/versions.yml4.43.3inpackages/cli/cli/versions.ymlso the fix ships in the next CLI releaseTesting
Important Review Notes
sedrather than by re-running the seed generator. CI seed tests pass, confirming the snapshots match generated output.ReadmeGenerator.ts:592— everything else is snapshot/fixture updates.Human Review Checklist
4.43.3is the correct next CLI version (latest is4.43.2)irVersion: 65is correct for the new CLI changelog entry:0.0.1suffix looks rightLink to Devin session: https://app.devin.ai/sessions/d0644705d81c41bbb4034d4e2345b110
Requested by: @jsklan