Skip to content

chore(go, python, ruby, rust): pretty-print wiremock-mappings.json#14208

Merged
jsklan merged 8 commits intomainfrom
devin/1774623087-format-wiremock-json
Mar 27, 2026
Merged

chore(go, python, ruby, rust): pretty-print wiremock-mappings.json#14208
jsklan merged 8 commits intomainfrom
devin/1774623087-format-wiremock-json

Conversation

@jsklan
Copy link
Copy Markdown
Contributor

@jsklan jsklan commented Mar 27, 2026

Description

Format generated wiremock-mappings.json files with 2-space indentation to reduce diff sizes on subsequent SDK generations. Previously these files were emitted as single-line JSON, making diffs unnecessarily large.

Changes Made

  • Changed JSON.stringify(wireMockConfigContent)JSON.stringify(wireMockConfigContent, null, 2) in 4 generators:
    • generators/python-v2/sdk/src/wire-tests/WireTestSetupGenerator.ts
    • generators/go-v2/sdk/src/wire-tests/WireTestSetupGenerator.ts
    • generators/ruby-v2/sdk/src/wire-tests/WireTestSetupGenerator.ts
    • generators/rust/sdk/src/wire-tests/WireTestSetupGenerator.ts
  • The PHP generator already used JSON.stringify(wireMockConfigContent, null, 2) — no change needed there.
  • Added versions.yml entries for all affected generators:
    • Go SDK: 1.31.5
    • Python SDK: 5.1.1
    • Ruby-v2 SDK: 1.1.6
    • Rust SDK: 0.27.1
  • Seed test snapshots regenerated (e.g. seed/go-sdk/exhaustive/no-custom-config/wiremock/wiremock-mappings.json)

Review Checklist

  • Verify version bumps are correct relative to the latest entries in each versions.yml
  • Confirm seed snapshot diffs are purely formatting changes (single-line → pretty-printed), no content differences

Testing

  • Lint/format check (pnpm run check) passes
  • All 143 CI checks pass (seed tests for all generators confirmed green)

Link to Devin session: https://app.devin.ai/sessions/8cc57c7e0de5471c8c3fc2ed2e584a59
Requested by: @jsklan


Open with Devin

Format the generated wiremock-mappings.json files with 2-space
indentation (JSON.stringify with null, 2) to reduce diff sizes
on subsequent SDK generations. PHP generator already had this;
now Python, Go, Ruby, and Rust generators match.

Co-Authored-By: judah <jsklan.development@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@fern-support fern-support changed the title chore(internal): pretty-print wiremock-mappings.json in all SDK generators chore(go, python, ruby, rust): pretty-print wiremock-mappings.json in all SDK generators Mar 27, 2026
@fern-support fern-support changed the title chore(go, python, ruby, rust): pretty-print wiremock-mappings.json in all SDK generators chore(go, python, ruby, rust): pretty-print wiremock-mappings.json Mar 27, 2026
@jsklan jsklan marked this pull request as ready for review March 27, 2026 16:47
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@jsklan jsklan enabled auto-merge (squash) March 27, 2026 16:47
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@jsklan jsklan closed this Mar 27, 2026
auto-merge was automatically disabled March 27, 2026 17:08

Pull request was closed

@jsklan jsklan reopened this Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

devin-ai-integration bot and others added 3 commits March 27, 2026 18:02
Co-Authored-By: judah <jsklan.development@gmail.com>
Co-Authored-By: judah <jsklan.development@gmail.com>
Co-Authored-By: judah <jsklan.development@gmail.com>
@jsklan jsklan merged commit a715201 into main Mar 27, 2026
162 checks passed
@jsklan jsklan deleted the devin/1774623087-format-wiremock-json branch March 27, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants