chore(go, python, ruby, rust): pretty-print wiremock-mappings.json#14208
Merged
chore(go, python, ruby, rust): pretty-print wiremock-mappings.json#14208
Conversation
Format the generated wiremock-mappings.json files with 2-space indentation (JSON.stringify with null, 2) to reduce diff sizes on subsequent SDK generations. PHP generator already had this; now Python, Go, Ruby, and Rust generators match. Co-Authored-By: judah <jsklan.development@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
fern-support
approved these changes
Mar 27, 2026
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
Co-Authored-By: judah <jsklan.development@gmail.com>
Co-Authored-By: judah <jsklan.development@gmail.com>
Co-Authored-By: judah <jsklan.development@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Format generated
wiremock-mappings.jsonfiles with 2-space indentation to reduce diff sizes on subsequent SDK generations. Previously these files were emitted as single-line JSON, making diffs unnecessarily large.Changes Made
JSON.stringify(wireMockConfigContent)→JSON.stringify(wireMockConfigContent, null, 2)in 4 generators:generators/python-v2/sdk/src/wire-tests/WireTestSetupGenerator.tsgenerators/go-v2/sdk/src/wire-tests/WireTestSetupGenerator.tsgenerators/ruby-v2/sdk/src/wire-tests/WireTestSetupGenerator.tsgenerators/rust/sdk/src/wire-tests/WireTestSetupGenerator.tsJSON.stringify(wireMockConfigContent, null, 2)— no change needed there.versions.ymlentries for all affected generators:seed/go-sdk/exhaustive/no-custom-config/wiremock/wiremock-mappings.json)Review Checklist
versions.ymlTesting
pnpm run check) passesLink to Devin session: https://app.devin.ai/sessions/8cc57c7e0de5471c8c3fc2ed2e584a59
Requested by: @jsklan