Skip to content

chore(seed): prepare seed fixtures for OpenAPI conversion#14257

Merged
jsklan merged 8 commits intomainfrom
jsklan/prepare-seed-fixtures-for-openapi-conversion
Mar 31, 2026
Merged

chore(seed): prepare seed fixtures for OpenAPI conversion#14257
jsklan merged 8 commits intomainfrom
jsklan/prepare-seed-fixtures-for-openapi-conversion

Conversation

@jsklan
Copy link
Copy Markdown
Contributor

@jsklan jsklan commented Mar 28, 2026

Summary

  • Disambiguate duplicate endpoint paths across 20 test-definition APIs so they can be exported to valid OpenAPI 3.0 specs
  • Generate openapi.yml alongside each Fern definition fixture (129 total) using fern export
  • Add scripts/export-openapi-test.sh to validate exports in parallel with CI-friendly output

Details

OpenAPI 3.0 requires unique (method, path) tuples. 20 seed fixtures had duplicate endpoints that prevented export. Each was resolved by giving conflicting endpoints unique paths (e.g., /token + /token/refresh, /movie + /movie/docs, etc.).

The generated openapi.yml files sit alongside the existing definition/ folders — fixtures still use Fern definitions as their source of truth.

Test plan

  • scripts/export-openapi-test.sh passes 129/129 (0 failures, 18 skipped as already-OpenAPI)

Open with Devin

jsklan added 4 commits March 27, 2026 16:52
Disambiguate endpoint paths across 20 test-definition APIs that had
duplicate (method, path) tuples, which OpenAPI 3.0 cannot represent.
Add export-openapi-test.sh script and generated openapi.yml outputs
for all 129 Fern-definition fixtures.
@jsklan jsklan self-assigned this Mar 28, 2026
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI
  • Postman

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

jsklan and others added 2 commits March 30, 2026 17:14
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 9 additional findings in Devin Review.

Open in Devin Review

@jsklan jsklan enabled auto-merge (squash) March 31, 2026 19:43
@jsklan jsklan closed this Mar 31, 2026
auto-merge was automatically disabled March 31, 2026 19:43

Pull request was closed

@jsklan jsklan reopened this Mar 31, 2026
@jsklan jsklan enabled auto-merge (squash) March 31, 2026 19:43
@jsklan jsklan closed this Mar 31, 2026
auto-merge was automatically disabled March 31, 2026 20:39

Pull request was closed

@jsklan jsklan reopened this Mar 31, 2026
@jsklan jsklan merged commit d66aa5e into main Mar 31, 2026
1192 of 1193 checks passed
@jsklan jsklan deleted the jsklan/prepare-seed-fixtures-for-openapi-conversion branch March 31, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants