fix(ci): use env vars instead of secrets in step if conditions

[davidkonigsberg]

Description

Fixes broken CI and Seed workflows on main introduced by #14676. Both ci.yml and seed.yml fail at workflow validation with:

Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.DOCKER_USERNAME_PUBLIC_READONLY != ''

The secrets context cannot be referenced directly in step-level if expressions (likely due to workflow_call being a trigger in seed.yml, which changes secrets context availability, and stricter validation in ci.yml).

Changes Made

• ci.yml (test-ete job, line 183): Changed if: ${{ secrets.DOCKER_USERNAME_PUBLIC_READONLY != '' }} → if: ${{ env.DOCKERHUB_USERNAME != '' }} with a step-level env mapping the secret to an env var
• seed.yml (benchmark job, line 869): Same fix

The with blocks still reference secrets directly for the actual login credentials, which is valid — only the if expression needed the workaround.

Review Checklist

• Confirm step-level env is evaluated before the step's if condition (per GitHub docs, it is)
• Verify that secrets in with: blocks still works correctly (it should — with inputs are evaluated in a different context than if)
• Note: the composite action (cached-seed) already avoids this issue by accepting credentials as inputs, not referencing secrets directly

Testing

• Workflow YAML syntax is valid
• Actual validation can only be confirmed by CI running successfully after merge

Link to Devin session: https://app.devin.ai/sessions/59c37d5afae04814afa3f96c447a28ab
Requested by: @davidkonigsberg

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[github-actions]

🌱 Seed Test Selector

Select languages to run seed tests for:

• Python
• TypeScript
• Java
• Go
• Ruby
• C#
• PHP
• Swift
• Rust
• OpenAPI

---

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.