fix(python): filter nop vals from objects in wire tests#14770
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
SDK Generation Benchmark ResultsComparing PR branch against latest nightly baseline on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
5765e3f to
aa62cda
Compare
SDK Generation Benchmark ResultsComparing PR branch against latest nightly baseline on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
Description
When an object property has a literal/const type (e.g.
strategywithconst: "adfs"),convertObjectEntriesinDynamicTypeLiteralMapperincludes it in the result even whenconvert()returns anop(). Sincenop()renders as empty string, this produces invalid Python syntax likestrategy=,. Nownops are filtered before returning fromconvertObjectEntries.Testing
On Auth0's MyOrg API.