Skip to content

fix(python): filter nop vals from objects in wire tests#14770

Merged
patrickthornton merged 1 commit into
mainfrom
patrick/python/another-wire-test-nop-fix
Apr 9, 2026
Merged

fix(python): filter nop vals from objects in wire tests#14770
patrickthornton merged 1 commit into
mainfrom
patrick/python/another-wire-test-nop-fix

Conversation

@patrickthornton
Copy link
Copy Markdown
Contributor

Description

When an object property has a literal/const type (e.g. strategy with const: "adfs"), convertObjectEntries in DynamicTypeLiteralMapper includes it in the result even when convert() returns a nop(). Since nop() renders as empty string, this produces invalid Python syntax like strategy=,. Now nops are filtered before returning from convertObjectEntries.

Testing

On Auth0's MyOrg API.

  • Unit tests added/updated
  • Manual testing completed

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-08T04:49:09Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
python-sdk square 168s 204s 166s -2s (-1.2%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-08T04:49:09Z). Trigger benchmark-baseline to refresh.

@patrickthornton patrickthornton force-pushed the patrick/python/another-wire-test-nop-fix branch from 5765e3f to aa62cda Compare April 9, 2026 13:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-09T04:46:50Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
python-sdk square 130s 166s 124s -6s (-4.6%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-09T04:46:50Z). Trigger benchmark-baseline to refresh.

@patrickthornton patrickthornton merged commit 5cbad61 into main Apr 9, 2026
93 checks passed
@patrickthornton patrickthornton deleted the patrick/python/another-wire-test-nop-fix branch April 9, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants