fix(deps): update basic-ftp to 5.2.1 (GHSA-chqc-8p9q-pq6q)#14814
Merged
Conversation
…ity (GHSA-chqc-8p9q-pq6q) Co-Authored-By: unknown <>
…e basic-ftp 5.2.1 directly Co-Authored-By: unknown <>
davidkonigsberg
approved these changes
Apr 9, 2026
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
@davidkonigsberg — updated: removed the override per your suggestion. Simply regenerating the lockfile was sufficient since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs Dependabot Alert #1412
Resolves HIGH severity CRLF injection vulnerability in
basic-ftp@5.2.0(GHSA-chqc-8p9q-pq6q, CVSS 8.6) by updating to5.2.1.basic-ftpis a transitive dependency (puppeteer→@puppeteer/browsers→proxy-agent→pac-proxy-agent→get-uri→basic-ftp). Sinceget-uri@6.0.5specifiesbasic-ftp: ^5.0.2, regenerating the lockfile was sufficient to pick up5.2.1— no pnpm override was needed.Changes Made
pnpm-lock.yamlto resolvebasic-ftp@5.2.1(previously5.2.0).github/dependabot-alerts/alert-1412.mdTesting
pnpm installsucceeds and lockfile resolvesbasic-ftp@5.2.1Link to Devin session: https://app.devin.ai/sessions/61725b6a88614f7ba6f7346d2ba06e59