Skip to content

fix(python): wire tests use package_path for imports#14828

Merged
patrickthornton merged 1 commit into
mainfrom
patrick/python/wire-test-package-path
Apr 9, 2026
Merged

fix(python): wire tests use package_path for imports#14828
patrickthornton merged 1 commit into
mainfrom
patrick/python/wire-test-package-path

Conversation

@patrickthornton
Copy link
Copy Markdown
Contributor

@patrickthornton patrickthornton commented Apr 9, 2026

Description

Wire tests wouldn't take into account package_path in the config to give the most qualified possible imports in wire tests, which was fine unless customers changed the init.py to not re-export types at top-level. Now wire tests import from the fully specified from seed.matryoshka.doll.structure import SeedExhaustive instead of from Seed import SeedExhaustive, for instance.

Changes Made

Feed package_path into the base config schema so the dynamic snippet generator can use it during import.

Testing

The exhaustive:package_path fixture shows the changes in the README.md and reference.md

  • Unit tests added/updated
  • Manual testing completed

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

🌱 Seed Test Selector

Select languages to run seed tests for:

  • Python
  • TypeScript
  • Java
  • Go
  • Ruby
  • C#
  • PHP
  • Swift
  • Rust
  • OpenAPI

How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR.

@patrickthornton patrickthornton changed the title fix(python): release 5.3.6 fix(python): wire tests use package_path for imports Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

SDK Generation Benchmark Results

Comparing PR branch against latest nightly baseline on main (2026-04-09T04:46:50Z).

Full benchmark table (click to expand)
Generator Spec main (generator) main (E2E) PR (generator) Delta
python-sdk square 130s 166s 129s -1s (-0.8%)

main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via fern generate). main (E2E): full customer-observable time including build/test scripts (nightly baseline, informational). Delta is computed against generator-only baseline.
⚠️ = generation exited with a non-zero exit code (timing may not reflect a successful run).
Baseline from nightly runs on main (latest: 2026-04-09T04:46:50Z). Trigger benchmark-baseline to refresh.

@patrickthornton patrickthornton merged commit adfe041 into main Apr 9, 2026
98 checks passed
@patrickthornton patrickthornton deleted the patrick/python/wire-test-package-path branch April 9, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants