fix(python): wire tests use package_path for imports#14828
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
package_path for imports
SDK Generation Benchmark ResultsComparing PR branch against latest nightly baseline on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
Description
Wire tests wouldn't take into account
package_pathin the config to give the most qualified possible imports in wire tests, which was fine unless customers changed the init.py to not re-export types at top-level. Now wire tests import from the fully specifiedfrom seed.matryoshka.doll.structure import SeedExhaustiveinstead offrom Seed import SeedExhaustive, for instance.Changes Made
Feed
package_pathinto the base config schema so the dynamic snippet generator can use it during import.Testing
The
exhaustive:package_pathfixture shows the changes in the README.md and reference.md