fix(cli): ship .gitattributes entries from fern replay init to Fiddle#15504
Merged
fern-support merged 2 commits intomainfrom Apr 28, 2026
Merged
fix(cli): ship .gitattributes entries from fern replay init to Fiddle#15504fern-support merged 2 commits intomainfrom
fern replay init to Fiddle#15504fern-support merged 2 commits intomainfrom
Conversation
`replayInit()` writes `.gitattributes` into a temp clone that is then discarded — the actual PR is built server-side by Fiddle, but the wire body never carried the entries, so generated PRs were missing the `linguist-generated=true` marker (e.g. auth0/auth0-python#833). Adds a `gitattributesEntries` field to `ReplayInitResult` and the Fiddle submit body (both v1 inline and v2 `submitReplayInit`). Drops the unused `replayYmlContent` field and the temp-clone writes that went nowhere. Requires a matching Fiddle change to consume the new field; until that lands the field is silently ignored (no regression).
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…gitattributes # Conflicts: # packages/generator-cli/versions.yml
fern-support
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fern replay initwrites.gitattributesinto a temp clone that gets discarded — the actual PR is built server-side by Fiddle, and the wire body never carried anygitattributesEntries. Result: generated PRs (e.g. auth0/auth0-python#833) only modify.fernignoreand.fern/replay.lock;.fern/replay.lockis never markedlinguist-generated=trueon GitHub.gitattributesEntries: string[]toReplayInitResultand to the JSON body posted to/api/remote-gen/replay/initfrom both the v1 inline submit (packages/cli/cli/src/cli.ts) andsubmitReplayInit(used by cli-v2).ReplayInitResult.replayYmlContentwas computed but never sent anywhere, and the twoensure*EntriesSync(repoPath)calls inreplay-init.tswrote to a temp dir that was immediately cleaned up. Both removed. Theensure*functions stay exported — they're still used byreplay-run.ts(local generation path, where they write to a real, committed output dir).Background
PR #14722 (Apr 7) attempted this same fix but only added the temp-clone writes; the wire format was never extended, so the bug persisted. The auth0 PR linked above is empirical proof.
Fiddle (separate repo) must be updated to read the new
gitattributesEntriesfield from the request body and apply each entry to.gitattributesin the PR it builds — analogous to howfernignoreEntriesis already applied to.fernignore. Until that lands the new field is silently ignored, so this PR is safe to merge first (no regression vs. today).Test plan
pnpm turbo run compile --filter @fern-api/generator-cli --filter @fern-api/cli --filter @fern-api/cli-v2— passespnpm turbo run test --filter @fern-api/generator-cli --filter @fern-api/cli-v2—generator-cli368 tests pass,cli-v2561 tests passGITATTRIBUTES_ENTRIESis exported and contains.fern/replay.lock linguist-generated=truecli-v2init command test: the body posted to/api/remote-gen/replay/initcontainsgitattributesEntries: [".fern/replay.lock linguist-generated=true"]fern replay init --github <repo>against a test SDK repo and confirm the resulting PR includes a.gitattributeschange adding the linguist-generated marker.Versioning
0.9.19topackages/generator-cli/versions.yml.packages/cli/cli/changes/unreleased/.pnpm-workspace.yamlleft at its current value (must reference a published version; pin will bump in a follow-up after CI publishes 0.9.19, mirroring the pattern from PR fix(cli): add .gitattributes creation and sync .fernignore entries with fern-replay #14722).