chore(cli-generator): sync cli-sdk@9c1f38f#16187
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
jsklan
approved these changes
Jun 2, 2026
5f7a888 to
87226fa
Compare
jsklan
added a commit
that referenced
this pull request
Jun 2, 2026
) PR #16187 (sync cli-sdk@9c1f38f) accidentally committed `_cli-sdk` as a submodule gitlink (mode 160000) with no `.gitmodules` backing it. The sync workflow checks out fern-api/cli-sdk into `_cli-sdk` at the repo root, and `peter-evans/create-pull-request` runs `git add -A` across the whole tree, capturing that nested clone as a phantom submodule. This breaks clean checkouts and `git submodule status` in downstream CI (Update Seed, etc.). - Remove the stray `_cli-sdk` gitlink from the tree. - Add `/_cli-sdk/` to .gitignore so no `git add -A` can capture it again. - Scope the sync workflow's create-pull-request step to `add-paths: generators/cli/sdk/` so it only stages the synced path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of fern-api/cli-sdk
mainHEAD intogenerators/cli/sdk/.Source:
cli-sdk@9c1f38fd0ffba8da21db241c07179f48fa0cecf7Generated by
.github/workflows/sync-cli-sdk.ymlviagenerators/cli/scripts/sync-sdk.sh.Seed tests (
pnpm seed test --generator cli) are the trust boundary — if they pass, a human reviewer can merge.