Conversation
jsklan
changed the title
tjb9dc
approved these changes
Oct 9, 2025
| } | ||
| context.logger.debug("Generated IR"); | ||
| const irVersionFromFdr = await getIrVersionForGenerator(generatorInvocation).then((version) => | ||
| version == null ? undefined : "v" + version.toString() |
Contributor
There was a problem hiding this comment.
bruhh are these not normalized? We have to add a v to it?
kennyderek
pushed a commit
that referenced
this pull request
Oct 14, 2025
…ersion to supply to the generator (#9815) * Try fetching the ir version from fdr for the generator * bump cli version * format * Update cli version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve IR migration by dynamically fetching IR version information from FDR instead of relying on hardcoded values. This change enhances the reliability and maintainability of the generator version compatibility system by querying the Fern registry for the exact IR version required by each generator.
Changes Made
getIrVersionForGeneratorfunction topackages/core/src/services/fdrGeneratorsSdk.tsto fetch IR versions from FDRgetIntermediateRepresentation.ts) to use FDR-sourced IRversions as fallback when no override is specified
createAndStartJob.ts) to use FDR-sourced IR versionsas fallback for Fiddle service
compatible-ir-versionsvalidation rule to use the centralizedgetIrVersionForGeneratorfunction0.86.1to CLI versions with appropriate changelog entrygetIrVersionForGeneratorfunction from core services moduleTesting