Expand test coverage with 1300+ lines of new tests#165
Conversation
Add 5 new test files (AnimationMerger, EditorViewport, MCPSettingsDialog, AnimationControlWidget, Material widget) and expand 6 existing test files (Manager, MaterialEditorQML, SkeletonDebug, SpaceCamera, TransformOperator, mainwindow) with additional test cases for signals, selections, transforms, and UI validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 993b010006
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/SpaceCamera_test.cpp
Outdated
| spaceCamera.setCameraSpeed(0.5f); | ||
| QKeyEvent pressEvent(QEvent::KeyPress, Qt::Key_Shift, Qt::ShiftModifier); | ||
| spaceCamera.keyPressEvent(&pressEvent); | ||
| EXPECT_GT(spaceCamera.getCameraSpeed(), 0.5f); |
There was a problem hiding this comment.
This expectation assumes pressing Shift changes camera speed, but SpaceCamera::keyPressEvent only adjusts speed for Qt::Key_Control and has no Shift branch (src/SpaceCamera.cpp), so the value remains 0.5f and this test fails deterministically; the same incorrect assumption also causes KeyReleaseShiftModifier to fail. Keeping this assertion breaks the test suite even when runtime behavior is correct.
Useful? React with 👍 / 👎.
The speed modifier in SpaceCamera is bound to Control (not Shift). Updated tests to press Control and verify the exact speed values (0.01 on press, 0.1 on release) instead of relying on relative comparisons against the mock's default speed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
1 participant
Summary
AnimationMerger_test.cpp,EditorViewport_test.cpp,MCPSettingsDialog_test.cpp,animationcontrolwidget_test.cpp,material_test.cppManager_test.cpp,MaterialEditorQML_test.cpp,SkeletonDebug_test.cpp,SpaceCamera_test.cpp,TransformOperator_test.cpp,mainwindow_test.cppNew test coverage areas
Test plan
🤖 Generated with Claude Code