test: improve coverage for MaterialComboDelegate and SceneTreeModel

[fernandotonon]

Summary

• add branch-focused tests for MaterialComboDelegate
• add broader behavioral tests for SceneTreeModel and SceneTreeItem
• cover commit/close editor signal paths, model material write paths, tree parent/index behavior, and selection toggling branches

Notes

• changes are test-only
• intended to increase overall coverage for CI/Sonar

Validation

• built UnitTests in local coverage build
• ran targeted suites:
  • MaterialComboDelegateTest.*
  • SceneTreeModelTests.*
  • SceneTreeItemTests.*

Summary by CodeRabbit

• Tests
  • Expanded unit test coverage for material combo delegate and selection set functionality to ensure robust behavior in edge cases and various operational conditions.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cdb37b86-9f67-4f0b-be1d-0c1ce7e56bf4

📥 Commits

Reviewing files that changed from the base of the PR and between 98ca2e9 and d1ced94.

📒 Files selected for processing (2)

• src/MaterialComboDelegate_test.cpp
• src/SelectionSet_test.cpp

---

📝 Walkthrough

Walkthrough

Two test files receive additional unit tests. MaterialComboDelegate_test.cpp gains tests for editor data handling without sub-entity context and signal behavior during close operations. SelectionSet_test.cpp gains tests for singleton lifecycle, empty selection handling, and position averaging across multiple nodes.

Changes

Cohort / File(s)	Summary
MaterialComboDelegate Tests src/MaterialComboDelegate_test.cpp	Added QMetaObject include and two tests: one verifying setEditorData behavior for material column without sub-entity context preserves selection state, another confirming commitAndCloseEditor invoked via QMetaObject does not emit signals when called without a sender.
SelectionSet Tests src/SelectionSet_test.cpp	Added three tests: SingletonKillAndRecreateProducesValidInstance validates singleton recreation after kill, GetResolvedEntitiesWithEmptySelectionReturnsEmptyList asserts empty list for cleared selection, and GetSelectionCenterWithMultipleNodesAveragesPositions verifies position averaging across multiple scene nodes.

Possibly related PRs

• Improve unit test coverage from master #221: Expands MaterialComboDelegate_test.cpp with tests covering material-column and editor-signaling behavior.
• Push coverage further on master #222: Modifies SelectionSet::getSelectionCenter functionality that is exercised by the new position-averaging test.
• Expand selection and mesh IO coverage #226: Adds tests for SelectionSet APIs including kill, getResolvedEntities, and getSelectionCenter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Five tests hopping in, so spry and bright,
Material combos and selections take flight!
No signals shall sneak without their say,
Positions average in just the right way!
The singleton lives, then dies, then springs back—
A rabbit's delight in the test-coverage track! 🥕✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description provides a clear summary of changes and validation steps, but lacks the structured sections specified in the template.	Restructure the description to match the template format with explicit 'Summary', 'Technical Details', 'Features', and 'Bugfixes' sections.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objective of adding test coverage for MaterialComboDelegate and SceneTreeModel, which aligns with the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/coverage-over-80-v2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud