Increase test coverage for TransformCommands, gizmos, and MCP read_file bounds#282
Conversation
…-80-again # Conflicts: # src/CLIPipeline_test.cpp # src/ScanEngine_test.cpp
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe PR extends the scan CLI with configurable filtering options (formats, file/mesh/material/vertex/animation constraints) and introduces CLI override precedence via a catch-all scope. Tests are added for gizmo query flag propagation, transform command undo/redo behavior, and filesystem API bounds clamping. Documentation is updated accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Summary
TransformCommandsundo/redo edge pathsScaleGizmoandTranslationGizmotests for query flag propagation and unknown object highlight behaviorMCPServerread_filecoverage formax_linesclamp behavior at low/high boundsTest updates
TransformCommandsTestsDuplicateCommand_RedoRecreatesAndSelectsCloneWithoutEntityGroupCommand_UndoRestoresChildrenToOriginalNonRootParentUngroupCommand_UndoRestoresGroupUnderOriginalParentAndSkipsForbiddenChildSubMeshTransformCommand_NonZeroSubMeshIndexTargetsCorrectSubMeshScaleGizmoTestsHighlightUnknownObjectReturnsZeroAndClearsHighlightTranslationGizmoTestsSetQueryFlagsAppliesToAllAxesHighlightUnknownObjectReturnsZeroAndClearsHighlightMCPServerTestReadFile_MaxLinesIsClampedToSupportedBoundsValidation
cmake --build build_cov_local --target UnitTests -j8Summary by CodeRabbit
New Features
scancommand with new CLI options for format filtering, size/mesh/material/vertex/animation constraints, skeleton/animation/texture/material presence checks, file naming case enforcement, and animation/bone name requirements.Documentation
qtmesh scandocumentation with new option flags and example invocations.