Skip to content

review(mcp): clarify mirror_pose dst-overwrite contract#600

Merged
fernandotonon merged 1 commit into
masterfrom
fix/mirror-pose-schema-doc
May 18, 2026
Merged

review(mcp): clarify mirror_pose dst-overwrite contract#600
fernandotonon merged 1 commit into
masterfrom
fix/mirror-pose-schema-doc

Conversation

@fernandotonon
Copy link
Copy Markdown
Owner

Codex P2 on PR #599 (merged): the schema description for dst implied "overwrites in place if same as src", but PoseLibrary::mirrorPose actually does an unconditional byName.insert(dst, ...) — any existing pose at dst is silently clobbered regardless of src.

Fix

Update the schema description so agents know dst is an unconditional overwrite and should be chosen carefully (or list_poses called first to avoid stomping unrelated poses).

Code behaviour unchanged; this is a doc-only fix.

🤖 Generated with Claude Code

Codex P2 on PR #599 (merged): the schema description for `dst`
implied "overwrites in place if same as src", but PoseLibrary
actually does an unconditional `byName.insert(dst, ...)` — any
existing pose at `dst` is silently clobbered regardless of `src`.

Fix: update the schema description so agents know `dst` is an
unconditional overwrite and should be chosen carefully (or
`list_poses` called first to avoid stomping unrelated poses).

Code behaviour unchanged; this is a doc-only fix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@fernandotonon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 4 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 09a4506a-3fb6-4d25-9c18-b9c23a2dbb13

📥 Commits

Reviewing files that changed from the base of the PR and between 504a61a and 16b1498.

📒 Files selected for processing (1)
  • src/MCPServer.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/mirror-pose-schema-doc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@fernandotonon fernandotonon merged commit 5ae3066 into master May 18, 2026
36 of 37 checks passed
@fernandotonon fernandotonon deleted the fix/mirror-pose-schema-doc branch May 18, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant