Redefined subarray in index.d.ts to return Buffer#298
Merged
dcousens merged 1 commit intofeross:masterfrom Oct 8, 2023
BTOdell:master
Merged
Redefined subarray in index.d.ts to return Buffer#298dcousens merged 1 commit intofeross:masterfrom BTOdell:master
dcousens merged 1 commit intofeross:masterfrom
BTOdell:master
Conversation
|
Could this pull be reviewed? It's been open since 2021. |
kinetikeith
approved these changes
Jan 28, 2023
kinetikeith
left a comment
kinetikeith
left a comment
There was a problem hiding this comment.
Declaration matches with official docs as well as the local implementation
dcousens
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297