Skip to content

Paths are not strings#16

Merged
Hoverbear merged 4 commits into
mainfrom
hoverbear/paths-are-not-strings
May 24, 2024
Merged

Paths are not strings#16
Hoverbear merged 4 commits into
mainfrom
hoverbear/paths-are-not-strings

Conversation

@Hoverbear
Copy link
Copy Markdown
Member

@Hoverbear Hoverbear commented May 23, 2024 •
edited
Loading

Gets rid of the idea that path: String and replaces it with path: PathBuf.

@Hoverbear Hoverbear self-assigned this May 23, 2024
@Hoverbear Hoverbear marked this pull request as ready for review May 23, 2024 20:19
@Hoverbear Hoverbear requested a review from emilyalbini May 23, 2024 20:19
@Hoverbear Hoverbear changed the title Hoverbear/paths are not strings Paths are not strings May 23, 2024
emilyalbini
emilyalbini previously approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilyalbini emilyalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@Hoverbear Hoverbear dismissed emilyalbini’s stale review May 24, 2024 13:07

The merge-base changed after approval.

@bors-ferrocene
Copy link
Copy Markdown
Contributor

bors-ferrocene Bot commented May 24, 2024

👎 Rejected by too few approved reviews

emilyalbini
emilyalbini previously approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilyalbini emilyalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors-ferrocene Bot added a commit that referenced this pull request May 24, 2024
@bors-ferrocene @Hoverbear
Merge #16
3236971 
16: Paths are not strings r=pietroalbini a=Hoverbear


Gets rid of the idea that `path: String` and replaces it with `path: PathBuf`.

Co-authored-by: Ana Hobden <operator@hoverbear.org>
Co-authored-by: Ana Hobden <ana.hobden@ferrous-systems.com>
@Hoverbear Hoverbear dismissed emilyalbini’s stale review May 24, 2024 13:13

The merge-base changed after approval.

@bors-ferrocene
Copy link
Copy Markdown
Contributor

bors-ferrocene Bot commented May 24, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Repository rule violations found\n\nAt least 1 approving review is required by reviewers with write access.\n\n","documentation_url":"https://docs.github.com/rest/git/refs#update-a-reference"}

@Hoverbear Hoverbear force-pushed the hoverbear/paths-are-not-strings branch from 11721d2 to ce66fb7 Compare May 24, 2024 13:26
@Hoverbear Hoverbear requested a review from emilyalbini May 24, 2024 13:27
emilyalbini
emilyalbini approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilyalbini emilyalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub stop dismissing my reviews.

bors merge

@bors-ferrocene
Copy link
Copy Markdown
Contributor

bors-ferrocene Bot commented May 24, 2024

Build succeeded:

@Hoverbear Hoverbear merged commit 5887032 into main May 24, 2024
@bors-ferrocene bors-ferrocene Bot deleted the hoverbear/paths-are-not-strings branch May 24, 2024 13:32
@emig emig mentioned this pull request Apr 22, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emilyalbini emilyalbini emilyalbini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Hoverbear Hoverbear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hoverbear @emilyalbini