Qol auto detect surface to volume#1122
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
- Coverage 94.92% 94.80% -0.12%
==========================================
Files 44 44
Lines 3270 3310 +40
==========================================
+ Hits 3104 3138 +34
- Misses 166 172 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhdark
left a comment
There was a problem hiding this comment.
This is a great little quality of life change! Just made some small suggestions to allow things to still work in parallel.
| ) | ||
| self.interfaces = interfaces or [] | ||
| self.surface_to_volume = surface_to_volume or {} | ||
| self.surface_to_volume = {} |
There was a problem hiding this comment.
Should we add some kind of "deprecation" warning only for the next release, just noting that this is no longer required to be given by the user if a non-empty dict is given? Even though its not a deprecation
There was a problem hiding this comment.
yes there is a a DeprecationWarning in HydrogenTransportProblemDiscontinuous.initialise()
Co-authored-by: James Dark <65899899+jhdark@users.noreply.github.com>
Description
Needs #1118
Summary
This PR removes the need to explicitly define
surface_to_volumewhen initiliasing a HydrogenTransportProblemDiscontinuous classRelated Issues
Fixes #1117
Type of Change
Testing
pytest)Code Quality Checklist
ruff format .)ruff check .)Documentation
Breaking Changes
Screenshots/Examples
Additional Notes