Skip to content

Formulation#587

Merged
jhdark merged 8 commits into
fenicsxfrom
formulation
Oct 10, 2023
Merged

Formulation#587
jhdark merged 8 commits into
fenicsxfrom
formulation

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Oct 6, 2023

This PR adds two methods to HTransportProblem:

  • create_formulation
  • create_solver

It simply moves things around for now but I think it adds the main building blocks

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ca94410) 0.00% compared to head (194fe21) 89.31%.

Additional details and impacted files
@@             Coverage Diff              @@
##           fenicsx     #587       +/-   ##
============================================
+ Coverage     0.00%   89.31%   +89.31%     
============================================
  Files            4        5        +1     
  Lines           79      131       +52     
============================================
+ Hits             0      117      +117     
+ Misses          79       14       -65     
Files Coverage Δ
festim/__init__.py 58.82% <100.00%> (+58.82%) ⬆️
festim/species.py 88.88% <88.88%> (ø)
festim/hydrogen_transport_problem.py 90.90% <86.36%> (+90.90%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin marked this pull request as ready for review October 9, 2023 15:57
@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from fenicsx to main October 9, 2023 15:58
@RemDelaporteMathurin RemDelaporteMathurin changed the base branch from main to fenicsx October 9, 2023 15:59
@jhdark
Copy link
Copy Markdown
Collaborator

jhdark commented Oct 10, 2023

Looks good to me

@jhdark jhdark merged commit 85cb2f7 into fenicsx Oct 10, 2023
@RemDelaporteMathurin RemDelaporteMathurin deleted the formulation branch October 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants