Skip to content

GitHub actions CI workflow#589

Merged
RemDelaporteMathurin merged 6 commits into
festim-dev:fenicsxfrom
jhdark:github_actions_CI
Oct 8, 2023
Merged

GitHub actions CI workflow#589
RemDelaporteMathurin merged 6 commits into
festim-dev:fenicsxfrom
jhdark:github_actions_CI

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Oct 8, 2023

Proposed changes

This would allow us to have Continuous Integration within Github using actions. Another amendment can be made to export the codecov report however this would require access to a secret token. At the moment this only runs on PR's however could be amended to run on all push operations to certain branches

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark jhdark added the enhancement New feature or request label Oct 8, 2023
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the upload to codecov please?
This is the command we need to run:

curl -Os https://uploader.codecov.io/latest/linux/codecov

chmod +x codecov
./codecov -t ${CODECOV_TOKEN}

I've added the CODECOV_TOKEN secret to the repo.

You need to modify the pytest command accordingly:

pytest test/ --cov festim --cov-report xml --cov-report term

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
jhdark and others added 5 commits October 8, 2023 16:28
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (fenicsx@948c2ee). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             fenicsx    #589   +/-   ##
=========================================
  Coverage           ?   0.00%           
=========================================
  Files              ?       4           
  Lines              ?      79           
  Branches           ?       0           
=========================================
  Hits               ?       0           
  Misses             ?      79           
  Partials           ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit ca94410 into festim-dev:fenicsx Oct 8, 2023
@jhdark jhdark deleted the github_actions_CI branch October 8, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants