GitHub actions CI workflow#589
Merged
RemDelaporteMathurin merged 6 commits intoOct 8, 2023
Merged
Conversation
RemDelaporteMathurin
requested changes
Oct 8, 2023
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Can you add the upload to codecov please?
This is the command we need to run:
curl -Os https://uploader.codecov.io/latest/linux/codecov
chmod +x codecov
./codecov -t ${CODECOV_TOKEN}I've added the CODECOV_TOKEN secret to the repo.
You need to modify the pytest command accordingly:
pytest test/ --cov festim --cov-report xml --cov-report term
RemDelaporteMathurin
requested changes
Oct 8, 2023
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #589 +/- ##
=========================================
Coverage ? 0.00%
=========================================
Files ? 4
Lines ? 79
Branches ? 0
=========================================
Hits ? 0
Misses ? 79
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This would allow us to have Continuous Integration within Github using actions. Another amendment can be made to export the codecov report however this would require access to a secret token. At the moment this only runs on PR's however could be amended to run on all push operations to certain branches
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...