Subdomain classes

[jhdark]

Proposed changes

Introducing subdomains, the subdomains will be used to create the meshtags and measures of the simulation. Additionally, when material classes are made, they will be an attribute of a volume subdomain class.

Types of changes

What types of changes does your code introduce to FESTIM?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code refactoring
• Documentation Update (if none of the other choices apply)
• New tests

Checklist

• Black formatted
• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c95993e) 89.23% compared to head (59037d4) 91.77%.

Additional details and impacted files

@@             Coverage Diff             @@
##           fenicsx     #593      +/-   ##
===========================================
+ Coverage    89.23%   91.77%   +2.54%     
===========================================
  Files            5        7       +2     
  Lines          130      158      +28     
===========================================
+ Hits           116      145      +29     
+ Misses          14       13       -1     

Files	Coverage Δ
festim/__init__.py	63.15% <100.00%> (+4.33%)	⬆️
festim/hydrogen_transport_problem.py	94.18% <100.00%> (+3.41%)	⬆️
festim/mesh/mesh.py	100.00% <ø> (ø)
festim/mesh/mesh_1d.py	100.00% <ø> (ø)
festim/subdomain/surface_subdomain.py	100.00% <100.00%> (ø)
festim/subdomain/volume_subdomain.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RemDelaporteMathurin]

Things are starting to take shape

A few things:

• please take the habit to add docstrings to your test to detail what they do
• Please open an issue to implement check in the code to test that borders match with each other, the borders match with the start point and the end point of the mesh

[RemDelaporteMathurin]

Another round of comments

[RemDelaporteMathurin]

A couple of tiny comments. I think we can remove the dofs attribute of Subdomain1D since we don't use it anywhere else

After addressing these comments feel free to merge