Materials class and temperature processing#596
Merged
Conversation
jhdark
added
enhancement
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #596 +/- ##
===========================================
+ Coverage 91.77% 93.98% +2.21%
===========================================
Files 7 9 +2
Lines 158 183 +25
===========================================
+ Hits 145 172 +27
+ Misses 13 11 -2
☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Oct 12, 2023
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
First round of comments
RemDelaporteMathurin
requested changes
Oct 12, 2023
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Looks great!
I have a few more comments
Collaborator
Author
|
now contains a fix for issue #594 |
RemDelaporteMathurin
requested changes
Oct 12, 2023
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Some more comments.
If you're happy with the material implementation I would merge this without the boders check, and keep that for another PR as I have some comments on it.
Smaller PRs = better PRs
RemDelaporteMathurin
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introducing the Material class, this will be an argument of a VolumeSubdomain class and will define certain hydrogen transport properties within a given subdomain. Additionally, some minor processing of the temperature argument is added to ensure its in the correct format for the formulation. More complex temperature arguments to come in the future.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...