Skip to content

Mesh properties fdim and vdim#599

Merged
jhdark merged 6 commits into
festim-dev:fenicsxfrom
jhdark:mesh_properties
Oct 13, 2023
Merged

Mesh properties fdim and vdim#599
jhdark merged 6 commits into
festim-dev:fenicsxfrom
jhdark:mesh_properties

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Oct 13, 2023

Proposed changes

The mesh with this change will have the properties fdim - facet dimension and vdim - the cell dimension which can then be accessed later.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark jhdark added the fenicsx Issue that is related to the fenicsx support label Oct 13, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dcb3b8c) 93.98% compared to head (54d9f21) 94.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #599      +/-   ##
===========================================
+ Coverage    93.98%   94.08%   +0.09%     
===========================================
  Files            9        9              
  Lines          183      186       +3     
===========================================
+ Hits           172      175       +3     
  Misses          11       11              
Files Coverage Δ
festim/hydrogen_transport_problem.py 96.62% <100.00%> (-0.08%) ⬇️
festim/mesh/mesh.py 100.00% <100.00%> (ø)
festim/mesh/mesh_1d.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread test/test_mesh.py Outdated
jhdark and others added 2 commits October 13, 2023 11:13
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@jhdark
Copy link
Copy Markdown
Collaborator Author

jhdark commented Oct 13, 2023

If you're happy with this @RemDelaporteMathurin I'll merge

Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhdark jhdark merged commit f6f4590 into festim-dev:fenicsx Oct 13, 2023
@jhdark jhdark deleted the mesh_properties branch October 13, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fenicsx Issue that is related to the fenicsx support

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants