Check borders#601
Merged
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #601 +/- ##
===========================================
+ Coverage 94.08% 94.44% +0.35%
===========================================
Files 9 9
Lines 186 198 +12
===========================================
+ Hits 175 187 +12
Misses 11 11
☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Oct 13, 2023
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
A couple of comments:
- refactoring suggestions
- maybe
check_bordersshould be a method ofMesh1Dand takes as argument a list ofSubdomain1D
RemDelaporteMathurin
requested changes
Oct 13, 2023
Collaborator
RemDelaporteMathurin
left a comment
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Better name space
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
… check_borders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
A small feature to test the borders of the volume subdomains. Additional tests have been added to ensure it works. The current implementation only works in the case that only VolumeSubdomain1D are used, This will need to be accounted for in the future.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...