Skip to content

Mesh normal as property of F.Mesh#605

Merged
jhdark merged 10 commits into
festim-dev:fenicsxfrom
jhdark:mesh_normal
Oct 17, 2023
Merged

Mesh normal as property of F.Mesh#605
jhdark merged 10 commits into
festim-dev:fenicsxfrom
jhdark:mesh_normal

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Oct 16, 2023

Proposed changes

New property of the mesh which will allow for evaluating vectors normal to boundaries of the mesh for example.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark jhdark added enhancement New feature or request fenicsx Issue that is related to the fenicsx support labels Oct 16, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4836eba) 95.83% compared to head (4fb8584) 95.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           fenicsx     #605      +/-   ##
===========================================
+ Coverage    95.83%   95.88%   +0.04%     
===========================================
  Files           10       10              
  Lines          264      267       +3     
===========================================
+ Hits           253      256       +3     
  Misses          11       11              
Files Coverage Δ
festim/hydrogen_transport_problem.py 97.50% <100.00%> (-0.03%) ⬇️
festim/mesh/mesh.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread festim/mesh/mesh.py
Comment thread festim/hydrogen_transport_problem.py Outdated
jhdark and others added 2 commits October 17, 2023 15:19
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
@jhdark jhdark merged commit 2ce0c38 into festim-dev:fenicsx Oct 17, 2023
@jhdark jhdark deleted the mesh_normal branch October 17, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fenicsx Issue that is related to the fenicsx support

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants