Skip to content

Remove conda workflow temporarily#608

Merged
jhdark merged 1 commit into
festim-dev:fenicsxfrom
jhdark:remove_conda_workflow
Oct 17, 2023
Merged

Remove conda workflow temporarily#608
jhdark merged 1 commit into
festim-dev:fenicsxfrom
jhdark:remove_conda_workflow

Conversation

@jhdark
Copy link
Copy Markdown
Collaborator

@jhdark jhdark commented Oct 17, 2023

Proposed changes

For now the installation of the fenics-dolfinx conda environment is very unreliable, often failing to initialise despite no change in how its defined. I propose that we halt testing on conda temporarily until It becomes more stable.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jhdark jhdark added the fenicsx Issue that is related to the fenicsx support label Oct 17, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a2fc5c3) 95.83% compared to head (b1f529f) 95.83%.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #608   +/-   ##
========================================
  Coverage    95.83%   95.83%           
========================================
  Files           10       10           
  Lines          264      264           
========================================
  Hits           253      253           
  Misses          11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

No need to remove the workflow file we can pause it in the settings

@jhdark jhdark reopened this Oct 17, 2023
@jhdark jhdark merged commit 4836eba into festim-dev:fenicsx Oct 17, 2023
@jhdark jhdark deleted the remove_conda_workflow branch October 19, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants