Fix conda workflow, new badges#610
Merged
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #610 +/- ##
===========================================
+ Coverage 95.83% 95.88% +0.04%
===========================================
Files 10 10
Lines 264 267 +3
===========================================
+ Hits 253 256 +3
Misses 11 11 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Oct 18, 2023
RemDelaporteMathurin
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
With the previous issues with conda, the workflow was disabled as it was inconsistent, often failing on setup of the environment. A small change is provided which changes how
mambais defined in setting up the environment.Additionally, badges of the workflow results are now shown on the README.md
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...