Support for XDMF export#613
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #613 +/- ##
===========================================
+ Coverage 96.68% 96.97% +0.29%
===========================================
Files 12 13 +1
Lines 362 397 +35
===========================================
+ Hits 350 385 +35
Misses 12 12
☔ View full report in Codecov by Sentry. |
jhdark
left a comment
There was a problem hiding this comment.
LGTM, the only thing is, its one thing verifying a file is created, but is there any way we can test the value in the output file to ensure its exporting correctly? Perhaps not
Co-authored-by: James Dark <65899899+jhdark@users.noreply.github.com>
Yeah no it isn't possible to read the file (XDMF or VTX) programmatically right now. The best we can do at the moment is checking the file is created and manual testing... |
Proposed changes
This PR adds a class to support XDMF export.
The XDMF format isn't maintained anymore so we may end up dropping support for it one day, but for now this is still a very valid option for exporting CG type functions.
Usage
Other:
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist